Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mod paths instead of include #33

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Use mod paths instead of include #33

merged 1 commit into from
Oct 24, 2023

Conversation

ColonelThirtyTwo
Copy link
Contributor

This approach still allows using the same files for Rc and Arc while preventing imports from leaking as well as working better with rust-analyzer.

@kirillsemyonkin
Copy link
Collaborator

I imagine this is being blocked by #35.

@kirillsemyonkin
Copy link
Collaborator

Sync master on your branches so that tests could rerun and succeed.

@ColonelThirtyTwo
Use mod paths instead of include
a6dc232 
This approach still allows using the same files for Rc and Arc while preventing
imports from leaking as well as working better with rust-analyzer.
@kirillsemyonkin kirillsemyonkin merged commit 40a5ec8 into yewstack:main Oct 24, 2023
12 checks passed
@cecton cecton mentioned this pull request Nov 6, 2023
Open
2 tasks
cecton pushed a commit to cecton/implicit-clone that referenced this pull request Nov 28, 2023
@ColonelThirtyTwo @cecton
Use mod paths instead of include (yewstack#33)
0dfe6d5 
This approach still allows using the same files for Rc and Arc while
preventing imports from leaking as well as working better with
rust-analyzer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ColonelThirtyTwo @kirillsemyonkin